regression: Move WorkspaceCredentials models to CE

[yash-rajpal]

Proposed changes (including videos or screenshots)

Migration 316 breaks community edition, the migration tries to use some models which are only present in EE, which crashes the server.

Fixing it by moving the required models to CE

Issue(s)

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: bf5cea6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ggazzo]

What happens if I don't have the license but then I install it?

[ggazzo]

I don't see much problem with a model being public, what we should be concerned about are the controllers/logic

[yash-rajpal]

What happens if I don't have the license but then I install it?

Good Question, I have no idea, maybe @Gustrb can help us.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33657/
on branch gh-pages at 2024-10-18 16:37 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (94a1119) to head (bf5cea6).
Report is 10 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33657   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20744    20744           
  Branches      5295     5295           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       621      621           

Flag	Coverage Δ
unit	74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

2nd vote for making the model CE. Nothing on the model needs to be EE as long as whatever is calling it is on EE.

[yash-rajpal]

3rd vote on moving the model to CE.

I'll take care of this.

[Gustrb]

Yea I think the best approach would be to make the models public and avoid having to do weird things such as migrating on license change

[yash-rajpal]

@ggazzo Moved the models to CE

[KevLehman]

Can you update the PR title as well? We're not skipping migration anymore