Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing new settings description #33660

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 18, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-103

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 2f7b14f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris marked this pull request as ready for review October 18, 2024 16:38
@dougfabris dougfabris merged commit 3eb5a1d into feat/single-contact-id Oct 18, 2024
11 of 12 checks passed
@dougfabris dougfabris deleted the fix/settings-description branch October 18, 2024 16:40
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33660/
on branch gh-pages at 2024-10-18 16:53 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (5e98135) to head (2f7b14f).
Report is 221 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33660       +/-   ##
===========================================================
+ Coverage                   58.43%   74.42%   +15.98%     
===========================================================
  Files                        2744      475     -2269     
  Lines                       66280    21050    -45230     
  Branches                    15001     5358     -9643     
===========================================================
- Hits                        38732    15666    -23066     
+ Misses                      24717     4743    -19974     
+ Partials                     2831      641     -2190     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 74.42% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants