Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Break big livechatTyped file into smaller modules #33720

Merged
merged 10 commits into from
Oct 23, 2024
Merged

chore: Break big livechatTyped file into smaller modules #33720

merged 10 commits into from
Oct 23, 2024

Conversation

KevLehman
Copy link
Member

@KevLehman KevLehman commented Oct 23, 2024 •
edited
Loading

3/N

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-762

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c40950

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33720/
on branch gh-pages at 2024-10-23 17:35 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (73ae901) to head (4c40950).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33720   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files          491      491           
  Lines        21532    21533    +1     
  Branches      5368     5368           
========================================
+ Hits         16270    16271    +1     
  Misses        4625     4625           
  Partials       637      637
Flag Coverage Δ
unit 75.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review October 23, 2024 17:31
@KevLehman KevLehman requested a review from a team as a code owner October 23, 2024 17:31
@KevLehman KevLehman added this to the 7.1.0 milestone Oct 23, 2024
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2024
@dionisio-bot dionisio-bot bot removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 23, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2024
@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 23, 2024
@ggazzo
Copy link
Member

ggazzo commented Oct 23, 2024

dio chill

@KevLehman
Copy link
Member Author

such obedient boi

@ggazzo
Copy link
Member

ggazzo commented Oct 23, 2024

/bark

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

AU AU

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2024
@kodiakhq kodiakhq bot merged commit 247b1c6 into develop Oct 23, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/break-livechattyped-2 branch October 23, 2024 19:48
ricardogarim pushed a commit that referenced this pull request Oct 28, 2024
@KevLehman @ricardogarim
chore: Break big livechatTyped file into smaller modules (#33720)
8574164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KevLehman @ggazzo @aleksandernsilva @MarcosSpessatto