Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exit if unhandledRejection during TEST_MODE #33724

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 23, 2024

ARCH-1308

after the first run:

image
I can conclude we have a few unhandled cases under development which is bad :s

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 92ad14a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.1.0 milestone Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33724/
on branch gh-pages at 2024-10-31 18:38 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (22e33d0) to head (92ad14a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33724   +/-   ##
========================================
  Coverage    75.40%   75.40%           
========================================
  Files          493      493           
  Lines        21487    21487           
  Branches      5336     5336           
========================================
  Hits         16202    16202           
  Misses        4645     4645           
  Partials       640      640           
Flag Coverage Δ
unit 75.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Oct 23, 2024
@ggazzo ggazzo force-pushed the chore/exit-during-test-mode branch from 48e95d8 to 63363e0 Compare October 31, 2024 03:12
@ggazzo ggazzo marked this pull request as ready for review October 31, 2024 03:13
@ggazzo ggazzo requested a review from a team as a code owner October 31, 2024 03:13
@ggazzo ggazzo force-pushed the chore/exit-during-test-mode branch from 63363e0 to 78f8f1b Compare October 31, 2024 18:34
@ggazzo ggazzo marked this pull request as draft October 31, 2024 19:05
@ggazzo ggazzo force-pushed the chore/exit-during-test-mode branch 2 times, most recently from 8165775 to 90a7ef0 Compare October 31, 2024 19:20
@ggazzo ggazzo force-pushed the chore/exit-during-test-mode branch from 90a7ef0 to 92ad14a Compare October 31, 2024 19:54
@ggazzo ggazzo marked this pull request as ready for review October 31, 2024 19:55
@ggazzo ggazzo merged commit 6008674 into develop Oct 31, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/exit-during-test-mode branch October 31, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants