Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag's Chip not being displayed correctly #33731

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 23, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-95

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: fbfb489

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33731/
on branch gh-pages at 2024-10-23 21:53 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (5e98135) to head (fbfb489).
Report is 300 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33731       +/-   ##
===========================================================
+ Coverage                   58.43%   75.44%   +17.00%     
===========================================================
  Files                        2744      491     -2253     
  Lines                       66280    21134    -45146     
  Branches                    15001     5338     -9663     
===========================================================
- Hits                        38732    15944    -22788     
+ Misses                      24717     4555    -20162     
+ Partials                     2831      635     -2196     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.44% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the fix/multi-tags-display branch from 2424bd8 to 089220b Compare October 23, 2024 23:31
@dougfabris dougfabris marked this pull request as ready for review October 24, 2024 00:47
@dougfabris dougfabris requested a review from a team as a code owner October 24, 2024 00:47
@tassoevan tassoevan merged commit 80bdb6a into feat/single-contact-id Oct 24, 2024
51 checks passed
@tassoevan tassoevan deleted the fix/multi-tags-display branch October 24, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants