-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ui-voip): Normalize @rocket.chat/ui-voip
unit tests
#33739
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33739 +/- ##
========================================
Coverage 75.56% 75.56%
========================================
Files 491 491
Lines 21533 21533
Branches 5368 5368
========================================
+ Hits 16271 16272 +1
+ Misses 4625 4624 -1
Partials 637 637
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
It enforces the usage of
userEvent
for simulating user interactions in unit tests. It also removes the unnecessary topdescribe
block in test suites and extracts state from anuseMemo
(unstable in concurrent rendering and suspense) to a ref.Issue(s)
Steps to test or reproduce
Further comments