Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui-voip): Normalize @rocket.chat/ui-voip unit tests #33739

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It enforces the usage of userEvent for simulating user interactions in unit tests. It also removes the unnecessary top describe block in test suites and extracts state from an useMemo (unstable in concurrent rendering and suspense) to a ref.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: c18750a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from a team October 24, 2024 06:21
@tassoevan tassoevan marked this pull request as ready for review October 24, 2024 06:21
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33739/
on branch gh-pages at 2024-10-24 06:30 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (72182ba) to head (c18750a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33739   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files          491      491           
  Lines        21533    21533           
  Branches      5368     5368           
========================================
+ Hits         16271    16272    +1     
+ Misses        4625     4624    -1     
  Partials       637      637           
Flag Coverage Δ
unit 75.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva self-requested a review October 24, 2024 11:52
@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Oct 24, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Oct 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 24, 2024
@kodiakhq kodiakhq bot merged commit c2b92f4 into develop Oct 24, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/voip-tests branch October 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants