Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add multiple fields validation #33771

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 24, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-126

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: e71b5da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33771/
on branch gh-pages at 2024-10-24 20:20 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (041c7aa) to head (e71b5da).
Report is 2 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33771      +/-   ##
==========================================================
- Coverage                   75.97%   75.97%   -0.01%     
==========================================================
  Files                         502      502              
  Lines                       21667    21667              
  Branches                     5377     5377              
==========================================================
- Hits                        16462    16461       -1     
- Misses                       4560     4561       +1     
  Partials                      645      645              
Flag Coverage Δ
unit 75.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 24, 2024 21:45
@dougfabris dougfabris requested a review from a team as a code owner October 24, 2024 21:45
@dougfabris dougfabris merged commit 756b005 into feat/single-contact-id Oct 24, 2024
52 checks passed
@dougfabris dougfabris deleted the fix/missing-multiple-validation branch October 24, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants