Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contact not merging for same email #33811

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 28, 2024

Proposed changes (including videos or screenshots)

Fixes the problem where the info used to verify a contact was case sensitive, resulting in a contact not being merged for similar contacts with different string cases.
(e.g. johndoe@example.comwas not merged with JOHNDOE@EXAMPLE.COM)

Issue(s)

SCI-116

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 28, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 49b0541

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tapiarafael tapiarafael marked this pull request as ready for review October 28, 2024 17:22
Copy link
Contributor

github-actions bot commented Oct 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33811/
on branch gh-pages at 2024-10-28 18:29 UTC

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (5e98135) to head (49b0541).
Report is 332 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33811       +/-   ##
===========================================================
+ Coverage                   58.43%   75.97%   +17.53%     
===========================================================
  Files                        2744      502     -2242     
  Lines                       66280    21667    -44613     
  Branches                    15001     5377     -9624     
===========================================================
- Hits                        38732    16461    -22271     
+ Misses                      24717     4561    -20156     
+ Partials                     2831      645     -2186     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.97% <0.00%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael requested review from a team as code owners October 28, 2024 18:20
@dougfabris dougfabris requested a review from a team as a code owner October 28, 2024 19:26
@dougfabris dougfabris merged commit 8f19747 into feat/single-contact-id Oct 28, 2024
51 checks passed
@dougfabris dougfabris deleted the fix/contact-merging branch October 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants