-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: contact not merging for same email #33811
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33811 +/- ##
===========================================================
+ Coverage 58.43% 75.97% +17.53%
===========================================================
Files 2744 502 -2242
Lines 66280 21667 -44613
Branches 15001 5377 -9624
===========================================================
- Hits 38732 16461 -22271
+ Misses 24717 4561 -20156
+ Partials 2831 645 -2186
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Fixes the problem where the info used to verify a contact was case sensitive, resulting in a contact not being merged for similar contacts with different string cases.
(e.g.
johndoe@example.com
was not merged withJOHNDOE@EXAMPLE.COM
)Issue(s)
SCI-116
Steps to test or reproduce
Further comments