-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky e2e test omnichannel-takeChat #33856
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33856 +/- ##
========================================
Coverage 75.42% 75.42%
========================================
Files 493 493
Lines 21499 21499
Branches 5337 5337
========================================
Hits 16215 16215
Misses 4644 4644
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
This PR changes the
getQueuedChat
selector to be exact. This prevents tests failing by selecting the incorrect room with similar name.Issue(s)
FLAKY-515
FLAKY-737
Steps to test or reproduce
user1
with a visitor named "Connie Willians" (example name)Further comments