Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky e2e test omnichannel-takeChat #33856

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 31, 2024

Proposed changes (including videos or screenshots)

This PR changes the getQueuedChat selector to be exact. This prevents tests failing by selecting the incorrect room with similar name.

Screenshot 2024-10-31 at 16 06 34

Issue(s)

FLAKY-515
FLAKY-737

Steps to test or reproduce

  • Create a conversation for user1 with a visitor named "Connie Willians" (example name)
  • Run the test with a visitor named "Connie"
  • Playwright will find "Connie Willians" instead of "Connie"
  • Test will fail

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 31, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 073ee6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva changed the title test: fix flaky omnichannel-takeChat test: flaky e2e test omnichannel-takeChat Oct 31, 2024
@aleksandernsilva aleksandernsilva changed the title test: flaky e2e test omnichannel-takeChat test: fix flaky e2e test omnichannel-takeChat Oct 31, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33856/
on branch gh-pages at 2024-10-31 19:18 UTC

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (daff9e1) to head (073ee6a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33856   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files          493      493           
  Lines        21499    21499           
  Branches      5337     5337           
========================================
  Hits         16215    16215           
  Misses        4644     4644           
  Partials       640      640           
Flag Coverage Δ
unit 75.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Oct 31, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 31, 2024 20:26
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner October 31, 2024 20:26
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Oct 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 31, 2024
@kodiakhq kodiakhq bot merged commit 974170d into develop Nov 1, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the test/take-chat-flaky branch November 1, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants