Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown verified contacts #33886

Merged

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Nov 5, 2024

Proposed changes (including videos or screenshots)

When a contact start the process of verification, we should not change the unknown status.

Issue(s)

SCI-150

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 7b22c1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33886/
on branch gh-pages at 2024-11-05 14:20 UTC

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (0c281a5) to head (7b22c1d).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33886   +/-   ##
=======================================================
  Coverage                   75.83%   75.83%           
=======================================================
  Files                         504      504           
  Lines                       21636    21636           
  Branches                     5346     5346           
=======================================================
  Hits                        16408    16408           
  Misses                       4580     4580           
  Partials                      648      648           
Flag Coverage Δ
unit 75.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc merged commit 33f955c into feat/single-contact-id Nov 5, 2024
50 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the fix/unkown-verified-contacts branch November 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants