feat: use contact's name on as omnichannel rooms' display name #33893
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33893 +/- ##
==========================================================
- Coverage 75.76% 75.75% -0.01%
==========================================================
Files 504 504
Lines 21660 21662 +2
Branches 5354 5355 +1
==========================================================
+ Hits 16410 16411 +1
Misses 4597 4597
- Partials 653 654 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
feat/single-contact-id
branch
from
a738619 to
0668978
Compare
| const visitor = await createVisitor(); | ||
| const room = await createLivechatRoom(visitor.token); |
There was a problem hiding this comment.
What about using let (globally in this describe) and deleting the visitor and closing the room on an afterEach instead?
Not a big deal, though
| if (!Object.keys(update).length) { | ||
| throw new Error('error-invalid-operation'); | ||
| } |
There was a problem hiding this comment.
It'd be nice if we had some sort of AtLeastOne type in core-typings so that this kind of error could be avoided
But also not a big deal, we can keep it like this if we need to move fast
Proposed changes (including videos or screenshots)
Issue(s)
SCI-114
Steps to test or reproduce
Further comments