feat: make Deno capture unhandled exceptions and rejections and report them to the server #33997
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0f61200 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33997 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 510 510
Lines 22063 22063
Branches 5385 5385
========================================
Hits 16723 16723
Misses 4694 4694
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d-gubert
force-pushed
the
feat/deno-unhandled-listeners
branch
from
0857b39 to
b41b2fe
Compare
KevLehman
approved these changes
Nov 19, 2024
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 4, 2024
This was referenced Dec 4, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 5, 2024
- [make Deno capture unhandled exceptions and rejections and report them to the server](RocketChat/Rocket.Chat#33997) - [apps-engine timeout config](RocketChat/Rocket.Chat#33690)
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 6, 2024
This was referenced Dec 9, 2024
|
/backport 7.0.1 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
d-gubert
added a commit
that referenced
this pull request
Dec 9, 2024
…t them to the server (#33997)
|
/backport 7.0.1 |
|
Pull request #34150 added to Project: "Patch 7.0.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The Deno subprocess will now catch any unhandled exceptions or rejections that happen and report those to the host process. These types of errors cause the subprocess to exit with code 1, so capturing and preventing them will make the apps more stable.
Uncaught exceptions should be rare, but unhandled promise rejections can be common if the app doesn't properly handle errors on its side.
Issue(s)
CONN-354
Steps to test or reproduce
Further comments