Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: notify users when a room is added to a team #34011

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Nov 20, 2024

Proposed changes (including videos or screenshots)

As described in SIDE-195, this change adds the ws event rooms-changes, triggered when a channel is added to or removed from a team.

Issue(s)

Steps to test or reproduce

Run RC server with environment variable DISABLED_DB_WATCHERS=true.

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 20, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 60101e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34011/
on branch gh-pages at 2024-11-26 18:33 UTC

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (7c0cda9) to head (60101e3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34011   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review November 21, 2024 16:57
@ricardogarim ricardogarim requested a review from a team as a code owner November 21, 2024 16:57
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Nov 26, 2024
@juliajforesti juliajforesti added this to the 7.2.0 milestone Nov 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 26, 2024
@kodiakhq kodiakhq bot merged commit db649ac into develop Nov 26, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the chore/notify-on-room-added-to-team branch November 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants