-
Notifications
You must be signed in to change notification settings - Fork 11.8k
feat: Workspace/subscription ux #34057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+222
−162
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3177e77
refactor: :recycle: Change WorkspaceCardSection header titles to h4
rique223 e030929
refactor: :recycle: Centralize seats and Monthly Active Contracts con…
rique223 53e3c41
refactor: :recycle: Centralize active sessions and Active sessions pe…
rique223 fa0349f
refactor: :recycle: Adjust spacing for PlanCardCommunity and AppsUsag…
rique223 d7e697e
wip: paliative for card min-height
rique223 c9d5136
Add proper minHeight and remove unnecessary margin
rique223 57ad4f9
refactor: :recycle: Paliative for workspace spacing
rique223 f5335f8
Remove unnecessary minHeight
rique223 8ec1530
feat: :sparkles: Componentize new WorkspaceCardSection title
rique223 5338758
Remove unnecessary artifacts
rique223 f4cc10e
fix: :bug: Version card background image responsivity
rique223 29c2b6c
Create sour-roses-invite.md
rique223 d48a6b5
Review
rique223 6012ae8
Merge branch 'refactor/workspace-subscription-ux' of github.com:Rocke…
rique223 cfd8d6c
feat: :sparkles: Componentize FeatureUsageCard body
rique223 9566a7f
Remove unnecessary props
rique223 43fd719
refactor: :recycle: Remove unnecessary titleToContentGap prop
rique223 4ecaddd
Merge branch 'develop' into refactor/workspace-subscription-ux
kodiakhq[bot] b519f1c
Merge branch 'develop' into refactor/workspace-subscription-ux
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@rocket.chat/meteor": minor | ||
--- | ||
|
||
Improves the workspace and subscription admin pages by updating font scaling, centralizing elements, | ||
enhancing responsiveness, and refactoring components to provide a better overall user experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
apps/meteor/client/views/admin/subscription/components/FeatureUsageCardBody.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { Box, CardBody } from '@rocket.chat/fuselage'; | ||
import type { ReactNode } from 'react'; | ||
import React from 'react'; | ||
|
||
type FeatureUsageCardBodyProps = { justifyContent?: 'flex-start' | 'center'; children: ReactNode }; | ||
|
||
const FeatureUsageCardBody = ({ justifyContent = 'center', children }: FeatureUsageCardBodyProps) => ( | ||
<CardBody> | ||
<Box h='full' w='full' display='flex' alignItems='center' justifyContent={justifyContent} flexDirection='column'> | ||
{children} | ||
</Box> | ||
</CardBody> | ||
); | ||
|
||
export default FeatureUsageCardBody; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
apps/meteor/client/views/admin/workspace/components/WorkspaceCardSectionTitle.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { Box } from '@rocket.chat/fuselage'; | ||
import React from 'react'; | ||
|
||
type WorkspaceCardSectionTitleProps = { | ||
variant?: 'p2b' | 'h4'; | ||
title: string; | ||
}; | ||
|
||
const WorkspaceCardSectionTitle = ({ variant = 'p2b', title }: WorkspaceCardSectionTitleProps) => ( | ||
<Box fontScale={variant} marginBlockEnd={variant === 'h4' ? 20 : 0}> | ||
{title} | ||
</Box> | ||
); | ||
|
||
export default WorkspaceCardSectionTitle; |
Unchanged files with check annotations Beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const { modifiedCount } = await updateAuditedByUser({ | ||
_id: this.userId, | ||
username: this.user.username!, | ||
ip: this.requestIp, | ||
useragent: this.request.headers['user-agent'] || '', | ||
})(Settings.updateValueById, key, value); | ||
const { modifiedCount } = await updateAuditedByUser({ | ||
_id: this.userId, | ||
username: this.user.username!, | ||
ip: this.requestIp, | ||
useragent: this.request.headers['user-agent'] || '', | ||
})(Settings.updateValueById, key, value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const auditSettingOperation = updateAuditedByUser({ | ||
_id: this.userId, | ||
username: this.user.username!, | ||
ip: this.requestIp, | ||
useragent: this.request.headers['user-agent'] || '', | ||
}); | ||
return resetAuditedSettingByUser({ | ||
_id: this.userId, | ||
username: this.user.username!, | ||
ip: this.requestIp, | ||
useragent: this.request.headers['user-agent'] || '', | ||
})(Settings.resetValueById, settingId); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const auditSettingOperation = updateAuditedByUser({ | ||
_id: this.userId, | ||
username: this.user.username!, | ||
ip: this.requestIp, | ||
useragent: this.request.headers['user-agent'] || '', | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const room = await Rooms.findOneById(rid); | ||
await Room.beforeTopicChange(room!); | ||
const update = await Rooms.setTopicById(rid, roomTopic); | ||
if (update && sendMessage) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
} | ||
try { | ||
const room = Rooms.findOne({ _id: this.roomId })!; | ||
if (!room.e2eKeyId) { | ||
this.setState(E2ERoomState.CREATING_KEYS); | ||
await this.createGroupKey(); | ||
// Import session key for use. | ||
try { | ||
const key = await importAESKey(JSON.parse(this.sessionKeyExportedString!)); | ||
// Key has been obtained. E2E is now in session. | ||
this.groupSessionKey = key; | ||
} catch (error) { | ||
await sdk.rest.post('/v1/e2e.updateGroupKey', { | ||
rid: this.roomId, | ||
uid: this.userId, | ||
key: await this.encryptGroupKeyForParticipant(e2e.publicKey!), | ||
} as any); | ||
await this.encryptKeyForOtherParticipants(); | ||
} catch (error) { | ||
const usersSuggestedGroupKeys = { [this.roomId]: [] as any[] }; | ||
for await (const user of users) { | ||
const encryptedGroupKey = await this.encryptGroupKeyForParticipant(user.e2e!.public_key!); | ||
const oldKeys = await this.encryptOldKeysForParticipant(user.e2e?.public_key, decryptedOldGroupKeys); | ||
usersSuggestedGroupKeys[this.roomId].push({ _id: user._id, key: encryptedGroupKey, ...(oldKeys && { oldKeys }) }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.