-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: username (Post as) field is not being updated in incoming webhook integration panel #34085
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34085 +/- ##
========================================
Coverage 75.75% 75.75%
========================================
Files 510 510
Lines 22078 22078
Branches 5387 5387
========================================
Hits 16726 16726
Misses 4706 4706
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
…k integration panel (#34085) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Proposed changes (including videos or screenshots)
This PR fixes a bug that happens when we need to update the “Post as” field, in the incoming webhook integration panel, and it’s not being updated in the database.
Issue(s)
Steps to test or reproduce
1- Go to workspace administration and then go to Integrations;
2- Select a incoming integration and try to update "Post as" field.
Further comments