Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: username (Post as) field is not being updated in incoming webhook integration panel #34085

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

hiagohubert
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR fixes a bug that happens when we need to update the “Post as” field, in the incoming webhook integration panel, and it’s not being updated in the database.

d461cad2-fd28-4007-b2a1-b5838e200d69

Issue(s)

Steps to test or reproduce

1- Go to workspace administration and then go to Integrations;
2- Select a incoming integration and try to update "Post as" field.

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 2b2c7c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 7.2.0 milestone Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34085/
on branch gh-pages at 2024-11-29 04:27 UTC

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (a11f41e) to head (2b2c7c4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34085   +/-   ##
========================================
  Coverage    75.75%   75.75%           
========================================
  Files          510      510           
  Lines        22078    22078           
  Branches      5387     5387           
========================================
  Hits         16726    16726           
  Misses        4706     4706           
  Partials       646      646           
Flag Coverage Δ
unit 75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes Nov 28, 2024
@hiagohubert hiagohubert added the stat: QA assured Means it has been tested and approved by a company insider label Dec 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 2, 2024
@kodiakhq kodiakhq bot merged commit 2c2a35a into develop Dec 2, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the SB-691 branch December 2, 2024 14:13
ggazzo added a commit that referenced this pull request Dec 5, 2024
…k integration panel (#34085)

Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants