Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change users room role action message not being displayed correctly #34503

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 24, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Closes #34288

Steps to test or reproduce

Further comments

CORE-905

dougfabris and others added 3 commits December 24, 2024 11:53
Co-authored-by: gabriellsh <gabriellsh@users.noreply.github.com>
Co-authored-by: gabriellsh <gabriellsh@users.noreply.github.com>
Co-authored-by: gabriellsh <gabriellsh@users.noreply.github.com>
Copy link
Contributor

dionisio-bot bot commented Dec 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 541c88a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title fix: change leader action message fix: Change users room role action message not being displayed correctly Dec 24, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34503/
on branch gh-pages at 2024-12-24 15:00 UTC

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (c7eedf8) to head (541c88a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34503   +/-   ##
========================================
  Coverage    59.27%   59.27%           
========================================
  Files         2820     2820           
  Lines        67881    67843   -38     
  Branches     15087    15075   -12     
========================================
- Hits         40236    40216   -20     
+ Misses       24823    24810   -13     
+ Partials      2822     2817    -5     
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 24, 2024 18:29
@dougfabris dougfabris requested a review from a team as a code owner December 24, 2024 18:29
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 24, 2024
@kodiakhq kodiakhq bot merged commit 86a21b5 into develop Dec 24, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/room-roles-message branch December 24, 2024 21:12
This was referenced Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Message Dispatches on changing User Role
2 participants