-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove deps from FederationRoomEvents model #34506
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34506 +/- ##
========================================
Coverage 59.28% 59.28%
========================================
Files 2820 2820
Lines 67903 67901 -2
Branches 15093 15093
========================================
- Hits 40254 40253 -1
+ Misses 24827 24826 -1
Partials 2822 2822
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Proposed changes (including videos or screenshots)
Use hardcoded queries instead of relying on
contextDefinitions
which is an external dependency since they're known from the context of the rooms model. This is also from a deprecated implementation of federation, so this code should be removed anytime soon.Issue(s)
Extracted from #34154
ARCH-1356
Steps to test or reproduce
Further comments