Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: DMs not working properly in embedded layout #34848

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 30, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-907

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 30, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: fbe8e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 30, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34848/
on branch gh-pages at 2024-12-31 14:48 UTC

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (3bc51d9) to head (fbe8e04).
Report is 1 commits behind head on release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.2.0   #34848      +/-   ##
=================================================
- Coverage          59.28%   59.28%   -0.01%     
=================================================
  Files               2820     2820              
  Lines              67932    67928       -4     
  Branches           15102    15101       -1     
=================================================
- Hits               40275    40271       -4     
  Misses             24831    24831              
  Partials            2826     2826              
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh marked this pull request as ready for review December 31, 2024 01:30
@gabriellsh gabriellsh requested a review from a team as a code owner December 31, 2024 01:30
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.3.0, 7.2.0 Dec 31, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to open this against the release branch?

@gabriellsh gabriellsh changed the base branch from develop to release-7.2.0 December 31, 2024 14:27
@gabriellsh gabriellsh requested review from a team as code owners December 31, 2024 14:27
@gabriellsh gabriellsh force-pushed the fix/embeddedReactivity branch from 2fa459f to 9adcfc3 Compare December 31, 2024 14:33
@gabriellsh gabriellsh force-pushed the fix/embeddedReactivity branch from 9adcfc3 to baf4844 Compare December 31, 2024 14:35
@tassoevan tassoevan merged commit 9d0c1bc into release-7.2.0 Dec 31, 2024
49 checks passed
@tassoevan tassoevan deleted the fix/embeddedReactivity branch December 31, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants