-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Room roles visibility in members panel #34850
feat: Room roles visibility in members panel #34850
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bf908f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole #34850 +/- ##
================================================================================================================
- Coverage 59.13% 59.13% -0.01%
================================================================================================================
Files 2819 2819
Lines 67865 67870 +5
Branches 15117 15117
================================================================================================================
+ Hits 40130 40132 +2
- Misses 24905 24907 +2
- Partials 2830 2831 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
e8d16bf
to
ff2748b
Compare
e9f0826
to
2491b43
Compare
c1b8e16
to
1089869
Compare
b203f45
to
2dbad30
Compare
9ca4955
to
f27518f
Compare
Added reactivity to the members list. The member's group now changes in the list when their role changes. Screen.Recording.2025-01-17.at.8.16.06.PM.mov |
f27518f
to
006f889
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
006f889
to
f2fa683
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
7ee0f4b
into
feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole
!! REQUIRES #34153 !!
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-504