Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Room roles visibility in members panel #34850

Conversation

MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Dec 30, 2024

!! REQUIRES #34153 !!

Proposed changes (including videos or screenshots)

Screenshot 2025-01-17 at 8 15 52 PM

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-504

@MartinSchoeler MartinSchoeler requested review from a team as code owners December 30, 2024 20:24
Copy link
Contributor

dionisio-bot bot commented Dec 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: bf908f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler marked this pull request as draft December 30, 2024 20:25
Copy link
Contributor

github-actions bot commented Dec 30, 2024

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34850/

Built to branch gh-pages at 2025-01-17 15:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (e4d6e64) to head (bf908f9).
Report is 1 commits behind head on feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole.

Additional details and impacted files

Impacted file tree graph

@@                                               Coverage Diff                                                @@
##           feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole   #34850      +/-   ##
================================================================================================================
- Coverage                                                                         59.13%   59.13%   -0.01%     
================================================================================================================
  Files                                                                              2819     2819              
  Lines                                                                             67865    67870       +5     
  Branches                                                                          15117    15117              
================================================================================================================
+ Hits                                                                              40130    40132       +2     
- Misses                                                                            24905    24907       +2     
- Partials                                                                           2830     2831       +1     
Flag Coverage Δ
unit 74.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin force-pushed the feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole branch from e8d16bf to ff2748b Compare January 10, 2025 14:37
@abhinavkrin abhinavkrin force-pushed the feat/members-virtuoso-group branch 2 times, most recently from e9f0826 to 2491b43 Compare January 15, 2025 14:16
@abhinavkrin abhinavkrin force-pushed the feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole branch 2 times, most recently from c1b8e16 to 1089869 Compare January 16, 2025 12:01
@abhinavkrin abhinavkrin force-pushed the feat/members-virtuoso-group branch 2 times, most recently from b203f45 to 2dbad30 Compare January 16, 2025 12:10
@abhinavkrin abhinavkrin marked this pull request as ready for review January 16, 2025 14:08
@abhinavkrin abhinavkrin added this to the 7.3.0 milestone Jan 16, 2025
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.3.0, 7.4.0 Jan 16, 2025
@abhinavkrin abhinavkrin force-pushed the feat/members-virtuoso-group branch from 9ca4955 to f27518f Compare January 17, 2025 14:47
@abhinavkrin
Copy link
Member

Added reactivity to the members list. The member's group now changes in the list when their role changes.

Screen.Recording.2025-01-17.at.8.16.06.PM.mov

@abhinavkrin abhinavkrin force-pushed the feat/members-virtuoso-group branch from f27518f to 006f889 Compare January 17, 2025 15:00
MartinSchoeler and others added 7 commits January 17, 2025 20:59
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin force-pushed the feat/members-virtuoso-group branch from 006f889 to f2fa683 Compare January 17, 2025 15:29
@abhinavkrin abhinavkrin removed this from the 7.4.0 milestone Jan 17, 2025
@abhinavkrin abhinavkrin added this to the 7.3.0 milestone Jan 17, 2025
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jan 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 17, 2025
@MartinSchoeler MartinSchoeler merged commit 7ee0f4b into feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole Jan 17, 2025
51 checks passed
@MartinSchoeler MartinSchoeler deleted the feat/members-virtuoso-group branch January 17, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants