Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Correct call of setModal #34871

Merged
merged 1 commit into from
Jan 3, 2025
Merged

refactor: Correct call of setModal #34871

merged 1 commit into from
Jan 3, 2025

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 3, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: 5cb4dd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added this to the 7.3.0 milestone Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34871/
on branch gh-pages at 2025-01-03 21:13 UTC

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (c5f23ab) to head (5cb4dd6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34871   +/-   ##
========================================
  Coverage    59.19%   59.19%           
========================================
  Files         2821     2821           
  Lines        67628    67622    -6     
  Branches     15045    15045           
========================================
  Hits         40031    40031           
+ Misses       24782    24776    -6     
  Partials      2815     2815           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review January 3, 2025 18:35
@tassoevan tassoevan requested a review from a team as a code owner January 3, 2025 18:35
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jan 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 3, 2025
@kodiakhq kodiakhq bot merged commit 6ec661b into develop Jan 3, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the refactor/set-modal branch January 3, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants