Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove getReadReceipts method calls (server) #34891

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

MarcosSpessatto
Copy link
Member

https://rocketchat.atlassian.net/browse/CORE-915

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 6, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 86849cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarcosSpessatto MarcosSpessatto added this to the 7.3.0 milestone Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34891/

Built to branch gh-pages at 2025-01-17 17:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (f7f35c3) to head (86849cf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34891    +/-   ##
=========================================
  Coverage    59.18%   59.18%            
=========================================
  Files         2819     2819            
  Lines        67719    67167   -552     
  Branches     15081    14970   -111     
=========================================
- Hits         40077    39755   -322     
+ Misses       24819    24611   -208     
+ Partials      2823     2801    -22     
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review January 7, 2025 16:16
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 17, 2025
@kodiakhq kodiakhq bot merged commit baaee3f into develop Jan 17, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the refactor/remove-read-receipts-method-calls branch January 17, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants