Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: SVG sanitization of Omnichannel rooms' icons #35043

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 28, 2025

Proposed changes (including videos or screenshots)

It compensates DOMPurify sanitization process, which wipes out SVG elements not contained in a <svg> root element.

Issue(s)

CONN-485

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 7.3.0 milestone Jan 28, 2025
@tassoevan tassoevan requested a review from a team as a code owner January 28, 2025 15:24
Copy link
Contributor

dionisio-bot bot commented Jan 28, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: dd75915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35043/

Built to branch gh-pages at 2025-01-28 15:38 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (3c4a9b8) to head (dd75915).
Report is 1 commits behind head on release-7.3.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.3.0   #35043   +/-   ##
==============================================
  Coverage          59.17%   59.17%           
==============================================
  Files               2821     2821           
  Lines              68131    68131           
  Branches           15152    15152           
==============================================
  Hits               40316    40316           
  Misses             24981    24981           
  Partials            2834     2834           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jan 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 28, 2025
@kodiakhq kodiakhq bot merged commit 61c2753 into release-7.3.0 Jan 28, 2025
43 of 45 checks passed
@kodiakhq kodiakhq bot deleted the regression/omnichannel-room-icons branch January 28, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants