Subscription audio notification #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed sound files
# Conflicts: # server/startup/migrations/v077.js
rodrigok
reviewed
Jan 3, 2017
rodrigok
previously requested changes
Jan 3, 2017
Closed
|
Translation is missing in Portuguese and in many other languages... translators do the work after our merges... |
|
I have fixed the issue with sounds being played based on currently opened room. Please review again @rodrigok ? Thanks. |
Conflicts: server/startup/migrations/v078.js
|
@marceloschmidt you need to resolve the conflicts now |
# Conflicts: # server/methods/saveUserPreferences.coffee # server/publications/subscription.coffee # server/startup/migrations/v083.js
# Conflicts: # server/startup/migrations/v084.js
marceloschmidt
dismissed
rodrigok’s stale review
i18n cache problems; the translation key exists
# Conflicts: # server/startup/migrations/v085.js
|
@marceloschmidt the admin menu |
|
@marceloschmidt Fixed 😃 |
rodrigok
approved these changes
Feb 7, 2017
| /* globals isSetNotNull, RocketChatTabBar */ | ||
| Template.adminSounds.helpers({ | ||
| isReady() { | ||
| if (isSetNotNull(() => Template.instance().ready)) { |
There was a problem hiding this comment.
What is the reason for use this isSetNotNull?
There was a problem hiding this comment.
CTRL+C, CTRL+V from adminEmoji :( should I remove it?
| ); | ||
|
|
||
| Template.adminSounds.events({ | ||
| ['keydown #sound-filter'](e) { |
There was a problem hiding this comment.
Why the selector is between brackets?
rodrigok
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #171
Closes #71
Related to #1268