Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic slack and rocket channels #6282

Closed
wants to merge 4 commits into from
Closed

Support for dynamic slack and rocket channels #6282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66ab652
Support for dynamic slack and rocket channels
Mar 8, 2017
a6c5a60
Support for dynamic slack and rocket channels
Mar 8, 2017
12923ce
Fixed eslint issue
Mar 8, 2017
6b237ee
Introduced ES2015 Import/Export to resolve dependencies
Mar 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rocketchat-slackbridge/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ The following can be configured in your Rocket.Chat Administration SlackBridge p

#### Group Chat Messages
* Send and receive basic messages
* Delete messages
* Delete messages (Can't delete slack message from rocket)
* Edit messages (Slack doesn't allow editing of BOT messages, so can't edit a Rocket msg in Slack)
* React to messages (as BOT in Slack)

Expand Down
4 changes: 3 additions & 1 deletion packages/rocketchat-slackbridge/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ logger = new Logger('SlackBridge', {
sections: {
connection: 'Connection',
events: 'Events',
class: 'Class'
class: 'Class',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more logger sections

slack: 'Slack',
rocket: 'Rocket'
}
});
5 changes: 5 additions & 0 deletions packages/rocketchat-slackbridge/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ Package.onUse(function(api) {

api.addFiles('logger.js', 'server');
api.addFiles('settings.js', 'server');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broke up the logic from slackbridge into rocket specific and slack specific files

api.addFiles('rocket.js', 'server');
api.addFiles('slack.js', 'server');
api.addFiles('slackbridge.js', 'server');
api.addFiles('slashcommand/slackbridge_import.server.js', 'server');

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting the objects from Rocket and Slack JS files so they could see each other

api.export("SB_SlackAdapter", 'server');
api.export("SB_RocketAdapter", 'server');
});

Npm.depends({
Expand Down
Loading