Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ui-vrecord Package to JS #6473

Merged
merged 8 commits into from
Mar 29, 2017
Merged

Convert ui-vrecord Package to JS #6473

merged 8 commits into from
Mar 29, 2017

Conversation

MartinSchoeler
Copy link
Contributor

@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6473 March 24, 2017 16:53 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6473 March 27, 2017 13:20 Inactive
rodrigok
rodrigok requested changes Mar 28, 2017
View reviewed changes
packages/rocketchat-ui-vrecord/client/VRecDialog.js Outdated
return c;
}
export const VRecDialog = new __initClass__(class {
static initClass() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a normal constructor?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6473 March 28, 2017 15:51 Inactive
rodrigok
rodrigok requested changes Mar 28, 2017
View reviewed changes
packages/rocketchat-ui-vrecord/client/VRecDialog.js Outdated
@@ -0,0 +1,63 @@
export const VRecDialog = class {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget the new?

test.txt Outdated
@@ -0,0 +1,264 @@
./packages/rocketchat-lib/client/MessageAction.coffee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add this by mistake?

rodrigok
rodrigok requested changes Mar 28, 2017
View reviewed changes
Copy link
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the VRecDialog from a global variable to an export, you should modify the files using it to import the file

@engelgabriel engelgabriel added this to the 0.55.0 milestone Mar 29, 2017
@engelgabriel engelgabriel merged commit 7a2e9f7 into develop Mar 29, 2017
@engelgabriel engelgabriel deleted the ui-vsrecords-to-js branch March 29, 2017 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinSchoeler @rodrigok @engelgabriel @marceloschmidt