Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Use tokenSentVia parameter for clientid/secret to token endpoint #6692

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

intelradoux
Copy link
Contributor

@RocketChat/core

Closes #4535

This just use the tokenSentVia parameter to sent clientID / secret to either parameter or header not both.

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2017

CLA assistant check
All committers have signed the CLA.


const allOptions = {
headers: {
'User-Agent': this.userAgent // http://doc.gitlab.com/ce/api/users.html#Current-user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to add a comma on this line

@intelradoux intelradoux force-pushed the develop branch 2 times, most recently from 4fb53f1 to 7a6e865 Compare April 16, 2017 07:33
@intelradoux
Copy link
Contributor Author

@sampaiodiego Sorry, I push the wrong local repo. Should be ok now.

@snahelou
Copy link

+1

@engelgabriel engelgabriel modified the milestones: 0.55.0, 0.56.0 Apr 18, 2017
@engelgabriel engelgabriel merged commit 6dc77da into RocketChat:develop Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants