Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Package to render issue numbers into links to an issue tracker. #6700

Merged
merged 3 commits into from
Aug 21, 2017

Conversation

TobiasKappe
Copy link
Contributor

This PR adds the package "rocketchat-issuelinks", which ensures that numbers preceded by a #-sign get converted into issue links. The exact link is configurable.

This package is incompatible with the "Hex Color Preview" plugin, which also uses the #-sign as an anchor to recognize numbers. As such, this feature is turned off by default.

@RocketChat/core

This package is incompatible with the "Hex Color Preview" plugin, which also
uses the #-sign as an anchor to recognize numbers.
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2017

CLA assistant check
All committers have signed the CLA.

Package.describe({
name: 'rocketchat:issuelinks',
version: '0.0.1',
summary: 'Message pre-processor that will add links to issue numbers.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: 'Message pre-processor that adds links to issue numbers.'

@engelgabriel engelgabriel modified the milestones: 0.55.0, 0.56.0 Apr 17, 2017
@TAdeJong
Copy link
Contributor

Alternative use: easily link relevant xkcd's!

@engelgabriel engelgabriel modified the milestones: 0.56.0, 0.57.0 May 9, 2017
@TobiasKappe
Copy link
Contributor Author

Any feedback?

@engelgabriel engelgabriel modified the milestones: 0.57.0, 0.58.0 Jun 19, 2017
@rodrigok rodrigok modified the milestones: 0.58.0, 0.59.0 Aug 1, 2017
@wampiedriessen
Copy link

This is a feature I would like to see, and a vital package for e.g. a development team! :)

@rodrigok rodrigok merged commit 4ef729b into RocketChat:develop Aug 21, 2017
@jasonfah
Copy link

Would it be unreasonable to ask for the key (# in this case) to be configurable?

For example for this to work with our case management system it would detect...

Case 123

Where it matches on case[space][0-9]

@ulope
Copy link

ulope commented Sep 1, 2017

This is a great start but unfortunately completely impractical for larger teams. In our company teams are working on 5 different projects. The minimum for a usable solution would be channel specific templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants