Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix iframe wise issues #6798

Merged
merged 3 commits into from
Apr 25, 2017
Merged

[FIX] Fix iframe wise issues #6798

merged 3 commits into from
Apr 25, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

  • 7b636a7 Try to directly install screen share extension or open a new windows if it's not allowed
  • e600442 Wait for iframe setting to start sending postMessages (previously some postMessage could being lost because the Iframe_Integration_send_enable was not loaded on the client yet)
  • 070a008 Hide users typing if on loaded on an iframe (to prevent the white space after the message input):

before:
image
after:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6798 April 25, 2017 20:41 Inactive
@engelgabriel engelgabriel added this to the 0.56.0 milestone Apr 25, 2017
@engelgabriel engelgabriel merged commit 2109970 into develop Apr 25, 2017
@engelgabriel engelgabriel deleted the fix-iframe-issues branch April 25, 2017 21:35
@rodrigok rodrigok mentioned this pull request May 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.56.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @engelgabriel