-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix hiding flex-tab on embedded view #7486
Conversation
& .messages-container { | ||
border-width: 0; | ||
|
||
& .flex-tab-container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a selector, you have a space after that dot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I don't get it.. there is no space after the dot and it's exactly the same as all other selectors =)
also you can see it working on heroku and the selector being used by google chrome:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the flex-tab-container
is a child of messages-container
you don't need the & there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is that correct or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigok @sampaiodiego it's correct, idk why but I saw a space after the dot yesterday.
@gdelavald actually you need to put &
before. We are using this css nesting draft on our implementation
& .messages-container { | ||
border-width: 0; | ||
|
||
& .flex-tab-container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigok @sampaiodiego it's correct, idk why but I saw a space after the dot yesterday.
@gdelavald actually you need to put &
before. We are using this css nesting draft on our implementation
@RocketChat/core
Using the embedded view mode (appending
?layout=embedded
to the URL) the flex-tab should be hidden. This behavior was changed by #7448Before:
After: