[NEW] Add room type identifier to room list header #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
changed the title
sampaiodiego
force-pushed
the
room-type-header
branch
from
962cc13
to
fa203fd
Compare
sampaiodiego
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
@danischreiber I've added the prefix type- to the class attribute and added a property so the favorites header can have a class as well.
sampaiodiego
force-pushed
the
room-type-header
branch
from
363f5c7
to
7ebb77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NEW] Add identifier so the name of the list can be modified (e.g., Channels -> Rooms)