[NEW] Add close button to flex tabs #7529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdelavald
approved these changes
Jul 19, 2017
|
This is a good addition, but the close button scrolls off the flextab panel along with content. I'd expect the close button to remain anchored to the top corner of the flex tab panel, not move with any scrollable content content |
|
@RichardFoxworthy thanks for the feedback.. which browser and OS are you using? on google chrome I can say the button stays at the top even if you scroll the content. |
|
@sampaiodiego I am using Chrome. The button scrolls with content in every tab except for 'Members' - see this example for Room Info tab. All the others do the same, except Members - http://recordit.co/RDpealQIrc |
|
you're right @RichardFoxworthy .. I think I was looking at members list only.. can you please open a issue for that? thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7435
What I did in most files was just removing the
<div class="content">because I added it to the container template: