[FIX] URL parse error fix for issue #7169 #7538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7169 #7482
The url parse issue happens in
sendMessage
while the regex match looks for a url pattern. This pattern ignore the(
and)
characters. This has been added in this PR.To test the regex you can use Regex101.com with the new regex
([A-Za-z]{3,9})://([-;:&=+$,\w]+@{1})?([-A-Za-z0-9.]+)+:?(\d+)?((/[-+=!:~%/.@,()\w]*)???([-+=&!:;%@/.,\w]+)?(?:#([^\s\)]+))?)?
Examples:
https://en.wikipedia.org/wiki/Bear_(disambiguation)
https://cs.wikipedia.org/wiki/Bylina_(pov%C4%9Bst)
Hope this helps!