Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] User avatar image background #7572

Merged
merged 3 commits into from
Jul 26, 2017
Merged

[FIX] User avatar image background #7572

merged 3 commits into from
Jul 26, 2017

Conversation

philipbrito
Copy link
Contributor

@RocketChat/core

This PR updates the const svg replacing the style attribute by the <rect SVG shape element to build the user avatar image background.

@sampaiodiego
Copy link
Member

on the same subject, what you think removing style of <text /> tag as well?

we can use font-weight and font-size attributes

@philipbrito
Copy link
Contributor Author

Thanks for your feedback @sampaiodiego ! Updated avatar.js!

@rodrigok rodrigok added this to the 0.58.0 milestone Jul 26, 2017
@rodrigok rodrigok merged commit 22e6116 into RocketChat:develop Jul 26, 2017
@philipbrito philipbrito mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.0
Development

Successfully merging this pull request may close these issues.
3 participants
@philipbrito @sampaiodiego @rodrigok