[FIX] File upload on multi-instances using a path prefix #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #ISSUE_NUMBER
When running RC with multi-instances and a path prefix like http://domain.com/rocket-chat, file uploads return an error when 2 requests are handled by different instances. The reason is req.url does not contain url prefix (it's stripped by Meteor https://github.com/meteor/meteor/blob/59aca741ccc22fbacc72786b94c97d74fb66e3a9/packages/webapp/webapp_server.js#L618) so when the request is rerouted to the correct instance it goes MIA.
I tested this change with 1 and many instances running, with a prefix and no prefix and using S3 and FileSystem.