[NEW] Add sweet alert to video call tab #8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's really needed @MartinSchoeler. |
|
Good stuff @MartinSchoeler |
karlprieb
approved these changes
Sep 20, 2017
|
@RocketChat/core Why can't this be added to this upcoming release? |
|
@graywolf336 since this is a new feature, we avoid adding those to RCs so we don't create any more bugs |
|
My opinion this is more a fix than a new addition, since it's too easy to randomly start new video calls and not mean it. But that's just my two cents.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7860
Adds a Sweet alert prompt before starting a video conference using the flex-tab button, hopefully this will reduce the amount of times that people start a video call by mistake
