Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more rtl issues #8194

Merged
merged 11 commits into from
Sep 20, 2017
Merged

Fix more rtl issues #8194

merged 11 commits into from
Sep 20, 2017

Conversation

karlprieb
Copy link
Contributor

@karlprieb karlprieb commented Sep 18, 2017 •
edited by engelgabriel
Loading

@RocketChat/core

Closes #8180
Closes #8181
Closes #8186
Closes #8187

  • Add cross icon to cancel button on modal and fix that button on RTL
    image

  • Fix unread message on RTL
    image

  • User is typing on RTL
    image

  • Fix message box placeholder direction on RTL
    image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8194 September 18, 2017 21:33 Inactive
@engelgabriel engelgabriel added this to the 0.59.0-rc.7 milestone Sep 19, 2017
@cyclops24
Copy link
Contributor

Thanks @karlprieb
In modal (create room) when we want add user a little padding required between username and user avatar. See this:
01
I mentioned this in #8186

@karlprieb
Copy link
Contributor Author

@cyclops24 Sorry, I forgot about that. I will add this fix to this PR :) Thank you!

@karlprieb
Copy link
Contributor Author

Fixed submit button on RTL
image

Fixed username padding on RTL
image

@rodrigok rodrigok changed the title [FIX] more rtl issues Fix more rtl issues Sep 20, 2017
@rodrigok rodrigok merged commit 21b1153 into develop Sep 20, 2017
@rodrigok rodrigok deleted the more-rtl-fixes branch September 20, 2017 12:37
rodrigok added a commit that referenced this pull request Sep 20, 2017
@rodrigok
Merge pull request #8194 from RocketChat/more-rtl-fixes
0bac5d8 
Fix more rtl issues
@cyclops24
Copy link
Contributor

@karlprieb , @rodrigok Cross icon to cancel button on modal ( #8186 ) still has bug in Firefox 55:
16
Other parts fixed completely, thanks @karlprieb 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

@gdelavald gdelavald Awaiting requested review from gdelavald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.7
4 participants
@karlprieb @cyclops24 @rodrigok @engelgabriel