Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Removing pipe and commas from custom emojis (#8168) #8237

Merged
merged 1 commit into from
Sep 23, 2017
Merged

[FIX] Removing pipe and commas from custom emojis (#8168) #8237

merged 1 commit into from
Sep 23, 2017

Conversation

matheusml
Copy link
Contributor

@RocketChat/core

Closes #8168

I also:

  • removed unused commented code
  • disabled commas from custom emojis

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel added this to the 0.59.0-rc.9 milestone Sep 23, 2017
@engelgabriel engelgabriel merged commit f667dd0 into RocketChat:develop Sep 23, 2017
rodrigok pushed a commit that referenced this pull request Sep 26, 2017
@engelgabriel @rodrigok
Merge pull request #8237 from matheusml/fix-8168
e0f8247 
[FIX] Removing pipe and commas from custom emojis (#8168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.9
Development

Successfully merging this pull request may close these issues.

Pipe character breaks emojis
3 participants
@matheusml @CLAassistant @engelgabriel