Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] some placeholder and phrase traslation fix #8269

Merged
merged 2 commits into from
Sep 23, 2017
Merged

[FIX] some placeholder and phrase traslation fix #8269

merged 2 commits into from
Sep 23, 2017

Conversation

cyclops24
Copy link
Contributor

@cyclops24 cyclops24 commented Sep 23, 2017 •
edited
Loading

@RocketChat/core

Closes #8268
I also rename key username to Username_Placeholder. I think it's better for placeholders.

We also need some key in language file:

"Username_Placeholder": "Please enter usernames...",
"Channel_Name_Placeholder": "Please enter channel name...",
"New_Password_Placeholder": "Please enter new password...",
"Name_Placeholder": "Please enter your name...",
"Email_Placeholder": "Please enter your email address...",

@cyclops24 cyclops24 changed the title [Fix] "Create Channel" modal placeholder not translatable [FIX] "Create Channel" modal placeholder not translatable Sep 23, 2017
@engelgabriel engelgabriel added this to the 0.59.0-rc.9 milestone Sep 23, 2017
@cyclops24 cyclops24 changed the title [FIX] "Create Channel" modal placeholder not translatable [WIP] "Create Channel" modal placeholder not translatable Sep 23, 2017
@cyclops24 cyclops24 changed the title [WIP] "Create Channel" modal placeholder not translatable [FIX] some placeholder and phrase traslation fix Sep 23, 2017
@engelgabriel engelgabriel merged commit 2532844 into RocketChat:develop Sep 23, 2017
rodrigok pushed a commit that referenced this pull request Sep 26, 2017
@engelgabriel @rodrigok
Merge pull request #8269 from intwarehq/some-translation-fix
929bada 
[FIX] some placeholder and phrase traslation fix
# Conflicts:
#	packages/rocketchat-ui-account/client/accountProfile.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.9
Development

Successfully merging this pull request may close these issues.

[BUG] [i18n] "Create Channel" modal placeholders not translatable
3 participants
@cyclops24 @engelgabriel @BabakScript