[FIX] Wrong message when resetting password and 2FA is enabled #8489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| title: t('Error_changing_password'), | ||
| type: 'error' | ||
| }); | ||
| if (error.error === 'totp-required') { |
There was a problem hiding this comment.
Does it throw this error even if successfully changing password?
There was a problem hiding this comment.
Yes, cuz after the change the process proceed to login, then we receive this error, if password was not changed the error will be different
geekgonecrazy
approved these changes
Oct 14, 2017
rodrigok
added a commit
that referenced
this pull request
Oct 17, 2017
…e-with-2fa [FIX] Wrong message when reseting password and 2FA is enabled
rodrigok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8472
When password is reset the user is logged in automatically, but one error is received when the user has 2FA enabled requiring to pass the token, that is why we have the password reset but one error is displayed.
This PR just check the error message and redirect the user to the login page when 2FA is required and show a success alert about the message reset.
The 2 possible results are: