[FIX] Invalid Code message for password protected channel #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
requested changes
Oct 14, 2017
| @@ -18,7 +18,7 @@ Meteor.methods({ | |||
| } | |||
|
|
|||
| if ((room.joinCodeRequired === true) && (code !== room.joinCode) && !RocketChat.authz.hasPermission(Meteor.userId(), 'join-without-join-code')) { | |||
| throw new Meteor.Error('error-code-invalid', 'Invalid Code', { method: 'joinRoom' }); | |||
| throw new Meteor.Error('error-code-invalid', 'Invalid Password', { method: 'joinRoom' }); | |||
There was a problem hiding this comment.
Shouldn't we say room password or room join code? I think password here is still just as ambiguous
There was a problem hiding this comment.
Ok, I'll change to Room Password
rodrigok
force-pushed
the
hotfix/join-code
branch
from
2966a9f
to
50f6616
Compare
|
@geekgonecrazy Can you review again? |
geekgonecrazy
approved these changes
Oct 14, 2017
rodrigok
added a commit
that referenced
this pull request
Oct 17, 2017
[FIX] Invalid Code message for password protected channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6106
Code