Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] encode filename in url to prevent links breaking #8551

Merged
merged 1 commit into from
Oct 23, 2017
Merged

[FIX] encode filename in url to prevent links breaking #8551

merged 1 commit into from
Oct 23, 2017
+1 −1

Conversation

joesitton
Copy link
Contributor

@RocketChat/core

Closes #6141

@graywolf336 graywolf336 mentioned this pull request Oct 19, 2017
Closed
karlprieb
karlprieb approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@karlprieb karlprieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! It's really great 👍

@rodrigok rodrigok added this to the 0.59.2 milestone Oct 23, 2017
@rodrigok rodrigok merged commit acfe83a into RocketChat:develop Oct 23, 2017
rodrigok added a commit that referenced this pull request Oct 25, 2017
@rodrigok
Merge pull request #8551 from joesitton/fix-upload-uri-error
1e99e7b 
[FIX] encode filename in url to prevent links breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.2
Development

Successfully merging this pull request may close these issues.

Cannot open attached file if filename contains "%"
3 participants
@joesitton @karlprieb @rodrigok