[FIX] DM email notifications always being sent regardless of account setting #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption setting has never been set
|
|
sampaiodiego
requested changes
Nov 23, 2017
There was a problem hiding this comment.
hey, thanks for you contribution =D
looks like this introduces a new bug. I did the following steps:
- registered a new user
- as an old user sent a direct message to the new one
- no email was sent
but the default configuration is to sent an email on every mention/dm, so it should be sending emails in this test.
|
Good spot. Looks like the logic on the existing code for |
The existing code logic was that if the user preference wasn't set then emails were defaulting to disabled. This should default to enabled.
|
I've tweaked that existing logic and it looks to be working as expected now. |
sampaiodiego
approved these changes
Nov 23, 2017
|
Looks good now =) thx again |
karlprieb
approved these changes
Nov 27, 2017
rodrigok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8619
PR #8810 fixed an issue with DM email notifications always being sent regardless of account setting. This had an issue though if the subscription had never been set (alluded to in a comment #8810 (comment)
This PR should fix that lingering issue.