Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Change old 'rocketbot' username to 'InternalHubot_Username' setting #8928

Merged
merged 3 commits into from
Dec 4, 2017

Conversation

ramrami
Copy link
Contributor

@ramrami ramrami commented Nov 23, 2017

@RocketChat/core

Before :

when typing an unknown command, rocketbot respond, we're expecting InternalHubot_Username

capture d ecran 2017-11-23 a 09 47 41

After :

capture d ecran 2017-11-23 a 09 52 29

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sampaiodiego
Copy link
Member

oh, you found a missing rocketbot 😂

I'm just thinking the impact of making the setting public, otherwise LGTM

@ramrami
Copy link
Contributor Author

ramrami commented Nov 23, 2017

@sampaiodiego I just found another one here 😄

@ramrami ramrami changed the title [FIX] Change old 'rocketbot' username when responding to 'No such command' [FIX] Change old 'rocketbot' username to 'InternalHubot_Username' setting Nov 23, 2017
@sampaiodiego sampaiodiego added this to the 0.60.0 milestone Nov 23, 2017
@rodrigok rodrigok merged commit 2c0cfd2 into RocketChat:develop Dec 4, 2017
@ramrami ramrami deleted the remove-rocketbot branch December 5, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants