[FIX] Added afterUserCreated trigger after first CAS login

[AmShaegar13]

@RocketChat/core

The afterUserCreated callback is not called when creating a user on first CAS login. This causes inconsistent behaviour with the 'User created' integration when using CAS.

This PR adds the missing trigger after a user is created by CAS login.

[rodrigok]

@AmShaegar13 Awesome, thanks. Can you do some changes?

The best place to put that code is here inside the Accounts.insertUserDoc, you should check if the user has username and then call that callback, then we will solve that problem for every place we call the Accounts.insertUserDoc passing username and not call the callback.

The reason for the if is that callback is called only by the method setUsername, meaning you have finished your registration.

What do you think?

[AmShaegar13]

@rodrigok no problem. Although I did not do it in the first place to avoid the callback being triggered for every user joining a live chat. Wouldn't that be the case?

Is that, what you want?

[rodrigok]

@AmShaegar13 Good point, that is not desired at all, we are working to remove livechat from user's collection anyways.

You can check if the user has username and type !== 'visitor', that solves the problem and keep the code in a central place. We could remove that on the next release when we finish the livechat users separation.

[rodrigok]

@AmShaegar13 Can we talk at https://open.rocket.chat/direct/rodrigo.nascimento ?

[AmShaegar13]

@rodrigok How about this?

[biomassives]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: acmeideal@gmail.com Domain biomassiv.es has exceeded the max emails per hour (110/100 (110%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o3.sgmail.github.com ([192.254.112.98]:53388) by chi-server32.websitehostserver.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from <bounces+848413-b37a-greg=biomassiv.es@sgmail.github.com>) id 1eNK72-002oy3-3W for greg@biomassiv.es; Fri, 08 Dec 2017 08:58:52 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=chm27a2ciaCNXx9dpz3fVcqguj4=; b=fA+hxmLMChh5YMnI WmMNKgNYo9B689Bn8552CaAsLRBGUPH2k4N8YJeJUqezqLZs0/toi+1xi0+X10Fm 7BlYZWplZO5OX/7mAQWvBlYU8RtZRw9KBrL60nhpq7Zyz0lueoDsfRLztJDxodaK jtYmgKeXs+D5XRYo+8rjVqv0RZU= Received: by filter0159p1iad2.sendgrid.net with SMTP id filter0159p1iad2-6538-5A2AA885-2C 2017-12-08 14:58:13.624146975 +0000 UTC Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0008p1iad1.sendgrid.net (SG) with ESMTP id M9oNmopcSy2qIbi-8xRp6A for <greg@biomassiv.es>; Fri, 08 Dec 2017 14:58:13.508 +0000 (UTC) Date: Fri, 08 Dec 2017 14:58:13 +0000 (UTC) From: Rodrigo Nascimento <notifications@github.com> Reply-To: "RocketChat/Rocket.Chat" <reply@reply.github.com> To: "RocketChat/Rocket.Chat" <Rocket.Chat@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <RocketChat/Rocket.Chat/pull/9022/review/82177532@github.com> In-Reply-To: <RocketChat/Rocket.Chat/pull/9022@github.com> References: <RocketChat/Rocket.Chat/pull/9022@github.com> Subject: Re: [RocketChat/Rocket.Chat] [FIX] added afterUserCreated trigger after first CAS login (#9022) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5a2aa8856a782_65cc3f9ee7662f2c64985"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: rodrigok X-GitHub-Recipient: biomassives X-GitHub-Reason: subscribed List-ID: RocketChat/Rocket.Chat <Rocket.Chat.RocketChat.github.com> List-Archive: https://github.com/RocketChat/Rocket.Chat List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+0042d4e274725940798c8224284cf57521e6f9f4db6ad21192cf0000000116426a8592a169ce10ad69cc@reply.github.com>, <https://github.com/notifications/unsubscribe/AELU4tQPuSaCIa8zM8ZNL0RO7nQO4eYEks5s-U6FgaJpZM4Q4HZ7> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: greg@biomassiv.es X-SG-EID: ZlaDthyue/4HG+EgTb7JoZYs48JNb2iQtCcPV6oIs9XK8XopkkuXFzoVuytcYdqQarEOVWGr5mSsyq W+TMcMIOlf2YgQGEMe2jHxfp/C4wbT82nMFaDxpu8eHxnWzkkUj3g1ZN08mbrLB5Fl7XoqTNW2utBg sPm+VJW7oZ+Fhs828OSxfg+h11cpJlNYWMH9MqtySZKwHQNzbcYG+sQklwJqg831AyXZTMqWXe196i s=

----==_mimepart_5a2aa8856a782_65cc3f9ee7662f2c64985 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit rodrigok approved this pull request.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #9022 (review) ----==_mimepart_5a2aa8856a782_65cc3f9ee7662f2c64985 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p><b>@rodrigok</b> approved this pull request.</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#9022 (review)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AELU4q2WsRBCOthFMS2_hKB1xDfsyyUiks5s-U6FgaJpZM4Q4HZ7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AELU4qracNfU1ljun4eeQvwkV_CLESbBks5s-U6FgaJpZM4Q4HZ7.gif" width="1" /></p> <div itemscope itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction"> <link itemprop="url" href="#9022 (review)"></link> <meta itemprop="name" content="View Pull Request"></meta> </div> <meta itemprop="description" content="View this Pull Request on GitHub"></meta> </div> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RocketChat/Rocket.Chat","title":"RocketChat/Rocket.Chat","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/RocketChat/Rocket.Chat"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rodrigok approved #9022"}],"action":{"name":"View Pull Request","url":"#9022 (review)"}}}</script> ----==_mimepart_5a2aa8856a782_65cc3f9ee7662f2c64985--