[NEW] Add impersonate option for livechat triggers #9107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Dec 20, 2017
| resolve({ | ||
| username: params.name | ||
| }); | ||
| } |
There was a problem hiding this comment.
🤔 it will never resolve if(params.sender !== 'custom')
| @@ -33,7 +33,24 @@ RocketChat.Livechat = { | |||
| return RocketChat.models.Users.findOnlineAgents(); | |||
| } | |||
| }, | |||
| getRoom(guest, message, roomInfo) { | |||
| getRequiredDepartment(onlineRequired = true) { | |||
There was a problem hiding this comment.
🤔 something like:
const departments = RocketChat.models.LivechatDepartment.findEnabledWithAgents();
return departments.fetch().find(dept => {
if (!dept.showOnRegistration) { return false; }
if (!onlineRequired) { return true; }
const onlineAgents = RocketChat.models.LivechatDepartmentAgents.getOnlineForDepartment(dept._id);
return onlineAgents.count() > 0
});
|
@ggazzo changes made, can you review it again pls? thx |
sampaiodiego
force-pushed
the
livechat-add-impersonate-option-to-triggers
branch
from
dd3816d
to
507cfa4
Compare
ggazzo
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8941
This adds a new option for a trigger action, you could choose between
Impersonate next agent from queueand the old one was moved toCustom agent:Selecting
Custom agentyou can provide him a name, and that name will be used to send a message when it triggers:Selecting
Impersonate next agent from queuea real agent will be used for sending the message. This option cannot be used ifGuest Poolrouting method is selected.The first time the trigger fires the next agent from queue will be fetched and then cached on client for 1 hour, this will prevent the multiple agents being showed in multiple windows.