-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] "Enter usernames" placeholder is cutting in "create channel" view #9194
Conversation
Idk if it's the best solution for it. It will break the input to the second line as soon we add a new tag/user. @karlprieb thoughts? |
@rodrigok with 70% it breaks at the second username and it is displayed correctly.. |
@TheReal1604 |
@ggazzo flex:1 seems to fix it at the first view.. BUT.. you get this after entering usernames (also cutted at the end): |
@TheReal1604 but it's better than create a new line after first tag or cut the placeholder at the beginning don't you think? |
@rodrigok For me as a user it looks really unpolished and broken if something gets cutted. :/ I think a better way is to hide the description of the field if a username is selected. This should look consistent. What you think? |
@karlprieb what do you think 🔝 |
@TheReal1604 @rodrigok I agree, we can use |
That sounds awesome! @karlprieb I have unfortunately no idea how to do the hiding thing. I correct the pull request to |
@TheReal1604 Yep, I'll take a look! :) |
@ggazzo meanwhile I'll merge this PR cuz it improves the current behavior. |
[FIX] "Enter usernames" placeholder is cutting in "create channel" view
@RocketChat/core
Closes #8785
before:
after: