-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Rooms and users are using different avatar style #9196
Conversation
4aa287b
to
ef0648c
Compare
Sorry, but I prefer the other way. This is now way too confusing. If you're dead set on making it this way, can we please make it a personal preference? |
@graywolf336 the idea is to prepare to when channels will have their own avatar.. so they will like pretty much as users.. I'm just not sure if we should have the new colored avatars for channels even on the small version. we could maybe have the "old way" (non-colored with just the icon) on the small version and have the colored/image avatar for channels on the big version.. |
I like this 🔝 I think on the large view its probably ok for avatars and/or showing this default name based image. But on small version I think we should keep the icons like they are now. I think by changing the colors like we have we've already changed a lot this version 😁 |
@graywolf336 @geekgonecrazy The current version (with lock/hash inside the colored square) will need to change as soon we have images for channels, that's why I moved the icon out. That is a design decision and @engelgabriel can explain. |
In these screens with lock/hash + image/avatar. That to me is a bit better 👍 Could we make it do single letter like in the screens? I think that might be difference between looking noisy and looking great like those mobile screenshots |
IMO that helps a lot. |
I like this option the best then. |
ef0648c
to
07ca35a
Compare
Fix: Rooms and users are using different avatar style
Fix: Rooms and users are using different avatar style
@RocketChat/core