Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rooms and users are using different avatar style #9196

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Dec 20, 2017

@RocketChat/core

image

image

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 20, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9196 December 20, 2017 00:19 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9196 December 20, 2017 00:21 Inactive
@graywolf336
Copy link
Contributor

Sorry, but I prefer the other way. This is now way too confusing. If you're dead set on making it this way, can we please make it a personal preference?

@sampaiodiego
Copy link
Member

@graywolf336 the idea is to prepare to when channels will have their own avatar.. so they will like pretty much as users..

I'm just not sure if we should have the new colored avatars for channels even on the small version. we could maybe have the "old way" (non-colored with just the icon) on the small version and have the colored/image avatar for channels on the big version..

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Dec 20, 2017

I'm just not sure if we should have the new colored avatars for channels even on the small version. we could maybe have the "old way" (non-colored with just the icon) on the small version and have the colored/image avatar for channels on the big version..

I like this 🔝 I think on the large view its probably ok for avatars and/or showing this default name based image. But on small version I think we should keep the icons like they are now.

I think by changing the colors like we have we've already changed a lot this version 😁

@rodrigok
Copy link
Member Author

@graywolf336 @geekgonecrazy The current version (with lock/hash inside the colored square) will need to change as soon we have images for channels, that's why I moved the icon out.

That is a design decision and @engelgabriel can explain.

@rodrigok
Copy link
Member Author

There is an option to reduce the noise, move the room icon to the right
image

@engelgabriel
Copy link
Member

We will merge this to keep it coherent with the new mobile design. I agree that avatars should be optional, and we will implement that option later.

image

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Dec 20, 2017

In these screens with lock/hash + image/avatar. That to me is a bit better 👍

Could we make it do single letter like in the screens? I think that might be difference between looking noisy and looking great like those mobile screenshots

@rodrigok
Copy link
Member Author

Another option to reduce the noise is reduce the initials to one letter
image

@geekgonecrazy
Copy link
Contributor

IMO that helps a lot.

@graywolf336
Copy link
Contributor

Another option to reduce the noise is reduce the initials to one letter

I like this option the best then.

@rodrigok
Copy link
Member Author

Another option
image

@rodrigok
Copy link
Member Author

image

@rodrigok rodrigok merged commit 57fe089 into develop Dec 20, 2017
@rodrigok rodrigok deleted the hotfix/room-icon branch December 20, 2017 20:04
rodrigok added a commit that referenced this pull request Dec 20, 2017
Fix: Rooms and users are using different avatar style
rodrigok added a commit that referenced this pull request Dec 20, 2017
Fix: Rooms and users are using different avatar style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants