Fix: Upload access control too distributed #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
approved these changes
Dec 21, 2017
| onValidate: FileUpload.uploadsOnValidate | ||
| onValidate: FileUpload.uploadsOnValidate, | ||
| onRead(fileId, file, req, res) { | ||
| if (FileUpload.requestCanAccessFiles(req)) { |
There was a problem hiding this comment.
if you could have this if testing the negative condition instead the positive one (like it is done here) I think it would be better =)
rodrigok
force-pushed
the
hotfix/upload-access
branch
from
bf7a4ec
to
f9980a4
Compare
rodrigok
added a commit
that referenced
this pull request
Dec 26, 2017
Fix: Upload access control too distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core