Changed callback not needed #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query is limited to `_id` only.
|
@mitar this publication is not used anymore |
|
Oh, where are then messages published? |
|
Messages are loaded in 2 steps:
|
|
Seems like this PR needs closed and the un-used publication needs removed? |
|
It is unused by core. hubot-rocketchat and rest-api's absolutely depend on it ;-) |
|
OK then absolutely don't remove! Haha |
|
Going to go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query is limited to
_idonly.I must say that I do not understand this publish function. Maybe some comments should be there?
Doesn't this publish function publish ALL deleted messages ever (with only
{_hidden: true}fields, though) for a given channel, every time user subscribes it? Because queryfindInvisibleByRoomIdis not limited in any way?