Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t mention user in DM #152

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Don’t mention user in DM #152

merged 1 commit into from
Aug 22, 2016

Conversation

timkinnane
Copy link
Contributor

@timkinnane timkinnane commented Aug 5, 2016

Hubot will mention the user in every reply by default:

user >> hubot ping
hubot >> @user pong

That makes sense in public channels, you need to see who hubot is talking to.

In a DM however, it looks bad having mentions with every reply when its just you and the bot talking. e.g.

user >> ping
hubot >> @user pong

This fixes that...

user >> ping
hubot >> pong

@geekgonecrazy
Copy link
Contributor

Thanks for the contribution 👍

@geekgonecrazy geekgonecrazy merged commit a55587b into RocketChat:streams Aug 22, 2016
@timkinnane timkinnane deleted the streams branch August 24, 2016 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants